linux-kernel - Re: [PATCH] staging: brcm80211: use kzalloc()

Open Source and information security mailing list archives

Date:	Mon, 8 Aug 2011 14:00:28 +0200
From:	"Roland Vossen" <rvossen@...adcom.com>
To:	"Thomas Meyer" <thomas@...3r.de>
cc:	"Greg Kroah-Hartman" <gregkh@...e.de>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: brcm80211: use kzalloc()

> Signed-off-by: Thomas Meyer<thomas@...3r.de>

Acked-by: Roland Vossen <rvossen@...adcom.com>

> ---
>
> diff -u -p a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c b/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
> --- a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c 2011-07-28 15:32:17.863253745 +0200
> +++ b/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c 2011-08-01 20:25:55.608031978 +0200
> @@ -6326,14 +6326,12 @@ brcmf_sdbrcm_chip_attach(struct brcmf_bu
>   	BRCMF_TRACE(("%s: Enter\n", __func__));
>
>   	/* alloc chip_info_t */
> -	ci = kmalloc(sizeof(struct chip_info), GFP_ATOMIC);
> +	ci = kzalloc(sizeof(struct chip_info), GFP_ATOMIC);
>   	if (NULL == ci) {
>   		BRCMF_ERROR(("%s: malloc failed!\n", __func__));
>   		return -ENOMEM;
>   	}
>
> -	memset((unsigned char *)ci, 0, sizeof(struct chip_info));
> -
>   	/* bus/core/clk setup for register access */
>   	/* Try forcing SDIO core to do ALPAvail request only */
>   	clkset = SBSDIO_FORCE_HW_CLKREQ_OFF | SBSDIO_ALP_AVAIL_REQ;
>
>
>
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives