lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 08 Aug 2011 17:06:17 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Johannes Weiner <jweiner@...hat.com>
Cc:	fuse-devel@...ts.sourceforge.net, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 2/2] fuse: mark pages accessed when written to

Johannes Weiner <jweiner@...hat.com> writes:

> As fuse does not use the page cache library functions when userspace
> writes to a file, it did not benefit from 'c8236db mm: mark page
> accessed before we write_end()' that made sure pages are properly
> marked accessed when written to.
>
> Signed-off-by: Johannes Weiner <jweiner@...hat.com>

Thanks, applied.

Miklos

> ---
>  fs/fuse/file.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 5c48126..471067e 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -14,6 +14,7 @@
>  #include <linux/sched.h>
>  #include <linux/module.h>
>  #include <linux/compat.h>
> +#include <linux/swap.h>
>  
>  static const struct file_operations fuse_direct_io_file_operations;
>  
> @@ -828,6 +829,8 @@ static ssize_t fuse_fill_write_pages(struct fuse_req *req,
>  		pagefault_enable();
>  		flush_dcache_page(page);
>  
> +		mark_page_accessed(page);
> +
>  		if (!tmp) {
>  			unlock_page(page);
>  			page_cache_release(page);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ