lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 08 Aug 2011 17:40:20 +0100
From:	Liam Girdwood <lrg@...nel.org>
To:	MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:	Axel Lin <axel.lin@...il.com>, linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	myungjoo.ham@...il.com, Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: max8952: removed unused mutex.

On Wed, 2011-08-03 at 09:58 +0900, MyungJoo Ham wrote:
> This patch removes a mutex that is never used in the driver.
> 
> Reported-by: Axel Lin
> Signed-off-by: MyungJoo Ham <myungjoo.ham@...sung.com>
> ---
>  drivers/regulator/max8952.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c
> index daff7fd..2fa8a81 100644
> --- a/drivers/regulator/max8952.c
> +++ b/drivers/regulator/max8952.c
> @@ -26,7 +26,6 @@
>  #include <linux/platform_device.h>
>  #include <linux/regulator/driver.h>
>  #include <linux/regulator/max8952.h>
> -#include <linux/mutex.h>
>  #include <linux/gpio.h>
>  #include <linux/io.h>
>  #include <linux/slab.h>
> @@ -47,7 +46,6 @@ enum {
>  struct max8952_data {
>  	struct i2c_client	*client;
>  	struct device		*dev;
> -	struct mutex		mutex;
>  	struct max8952_platform_data *pdata;
>  	struct regulator_dev	*rdev;
>  
> @@ -208,7 +206,6 @@ static int __devinit max8952_pmic_probe(struct i2c_client *client,
>  	max8952->client = client;
>  	max8952->dev = &client->dev;
>  	max8952->pdata = pdata;
> -	mutex_init(&max8952->mutex);
>  
>  	max8952->rdev = regulator_register(&regulator, max8952->dev,
>  			&pdata->reg_data, max8952);

Applied.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ