linux-kernel - Re: b43: LCN-PHY add place for new PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2011 23:02:50 +0200
From:	Rafał Miłecki <zajec5@...il.com>
To:	Gábor Stefanik <netrolller.3d@...il.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"John W. Linville" <linville@...driver.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-wireless@...r.kernel.org
Subject: Re: b43: LCN-PHY add place for new PHY support

W dniu 8 sierpnia 2011 18:07 użytkownik Gábor Stefanik
<netrolller.3d@...il.com> napisał:
> 2011/8/8 Rafał Miłecki <zajec5@...il.com>:
>> W dniu 8 sierpnia 2011 13:57 użytkownik Geert Uytterhoeven
>> <geert@...ux-m68k.org> napisał:
>>> On Sat, Jul 23, 2011 at 02:12, Linux Kernel Mailing List
>>> <linux-kernel@...r.kernel.org> wrote:
>>>> Gitweb:     http://git.kernel.org/linus/1d738e64f3d957d56c1b51e64ebdef986a8760e3
>>>> Commit:     1d738e64f3d957d56c1b51e64ebdef986a8760e3
>>>> Parent:     0cd20a278e1ef9da9f6a987942794c9d65af8c4d
>>>> Author:     Rafał Miłecki <zajec5@...il.com>
>>>> AuthorDate: Thu Jul 7 15:25:27 2011 +0200
>>>> Committer:  John W. Linville <linville@...driver.com>
>>>> CommitDate: Fri Jul 8 11:11:25 2011 -0400
>>>
>>>> diff --git a/drivers/net/wireless/b43/phy_lcn.h b/drivers/net/wireless/b43/phy_lcn.h
>>>> new file mode 100644
>>>> index 0000000..c046c2a
>>>> --- /dev/null
>>>> +++ b/drivers/net/wireless/b43/phy_lcn.h
>>>
>>>> \ No newline at end of file
>>>
>>> Woops...
>>>
>>> gcc/cpp also complains:
>>>
>>> drivers/net/wireless/b43/phy_lcn.h:14:28: warning: no newline at end of file
>>
>> Sorry, I didn't know we want empty lines at the end. I also don't
>> think it's mentioned in kernel's CodingStyle.
>
> I'm pretty sure it is basic Unix knowledge that all text files SHOULD
> (RFC 2119) end with a newline character, unless otherwise noted
> explicitly. In fact, many Unix text editors automatically insert a
> newline at the end, and forbid you from deleting it.

OK, thanks, will avoid that in the future.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/