linux-kernel - Re: [PATCH] video: Add a callback 'notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110809021258.GM27748@morell.nvidia.com>
Date:	Mon, 8 Aug 2011 19:12:58 -0700
From:	Robert Morell <rmorell@...dia.com>
To:	Dilan Lee <dilee@...dia.com>
Cc:	"rpurdie@...ys.net" <rpurdie@...ys.net>,
	"lethal@...ux-sh.org" <lethal@...ux-sh.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"arun.murthy@...ricsson.com" <arun.murthy@...ricsson.com>,
	"linus.walleij@...ricsson.com" <linus.walleij@...ricsson.com>,
	Jordan Nien <JNien@...dia.com>,
	Stephen Warren <swarren@...dia.com>,
	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] video: Add a callback 'notify_after' for backlight
 control

On Mon, Aug 08, 2011 at 07:05:25PM -0700, Dilan Lee wrote:
[...]
> For example, GPIO backlight_en has to be risen after pwm has been enabled
> to meet panel power on sequence defined in panel specification.

I still think this information is irrelevant/nonsensical here, and
should be omitted entirely..

[...]

>  	unsigned int		lth_brightness;
>  	int			(*notify)(struct device *,
> -					  int brightness);
> +					int brightness);

Please don't change the line above; unlike the one you added after, it
was already lined up properly with its argument list.

Otherwise,
Reviewed-by: Robert Morell <rmorell@...dia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/