linux-kernel - Re: [patch v4 1/7] crc32: move-to-documentation.diff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF2A1D4C02.965787E8-ONC12578E7.005C021E-C12578E7.005C7904@transmode.se>
Date:	Tue, 9 Aug 2011 18:50:02 +0200
From:	Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
To:	"George Spelvin" <linux@...izon.com>
Cc:	akpm@...ux-foundation.org, fzago@...temfabricworks.com,
	linux-kernel@...r.kernel.org, rdunlap@...otime.net,
	rpearson@...temfabricworks.com
Subject: Re: [patch v4 1/7] crc32: move-to-documentation.diff

"George Spelvin" <linux@...izon.com> wrote on 2011/08/09 13:45:04:
>
> Here's a hopefully-improved Documentation file, which explains the slicing
> algorithm as well.  As long as you have a big diff, it seems worth tweaking.
>
> You also might want to leave a pointer in lib/crc32.c to the relocated docs.
>
> (I'm just inclding the whole changed file because I assume it's easier
> to review that way; do you prefer a diff?)

Nice, reading this once again I think I found an old typo. See below

Perhaps Bob can add this addition to his patch series?

>
> === Cut here ===
...
> Or in little-endian:
> for (i = 0; i < input_bytes; i++) {
>    remainder ^= next_input_byte();
>    for (j = 0; j < 8; j++) {
>       multiple = (remainder & 1) ? CRCPOLY : 0;
>       remainder = (remainder << 1) ^ multiple;

Should not above line be:
       remainder = (remainder >> 1) ^ multiple;
?

>    }
> }
>
> If the input is a multiple of 32 bits, you can even XOR in a 32-bit
> word at a time and increase the inner loop count to 32.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/