linux-kernel - Re: [patch 1/1] [PATCH] include storage keys in hibernation image.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201108092156.12451.rjw@sisk.pl>
Date:	Tue, 9 Aug 2011 21:56:12 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, Pavel Machek <pavel@....cz>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [patch 1/1] [PATCH] include storage keys in hibernation image.

On Tuesday, August 09, 2011, Martin Schwidefsky wrote:
> On Fri, 29 Jul 2011 00:01:14 +0200
> "Rafael J. Wysocki" <rjw@...k.pl> wrote:
> 
> > Sorry for the extreme delay.
> 
> No big deal, I have been busy with other things anyway.
>  
> > Having reconsidered things I think the code under the #ifdef above
> > should really go to arch/s390.
> 
> Ok, that is reasonable.
>  
> > Now, for the purpose of exporting the headers I'd introduce
> > CONFIG_ARCH_SAVE_PAGE_KEYS and make S390 do
> > 
> > select ARCH_SAVE_PAGE_KEYS if HIBERNATION
> > 
> > and I'd put a #ifdef depending on that into include/linux/suspend.h.
> > 
> > Apart from this, I have only one complaint, which is that the kerneldoc
> > comments should follow the standard (the other comments in snapshot.c don't,
> > but that's a matter for a separate patch).
> 
> Sounds good. I will come up with new patches for this and resend them
> for review. Might be one or two weeks though, currently conferencing in
> Orlando..

OK, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/