| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Aug 2011 09:57:02 -0400
From: Padmavathi Venna <padma.v@...sung.com>
To: kgene.kim@...sung.com, linux@....linux.org.uk,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
grant.likely@...retlab.ca, jassisinghbrar@...il.com,
ben-linux@...ff.org
Subject: [RFC][PATCH 1/2] S5PV210: SPI: Add clkdev support
Create a clkdev alias for spi bus clock and modify the spi
driver to lookup the clock using the alias name instead of
passing clock name and clock number from SPI platform data.
Signed-off-by: Padmavathi Venna <padma.v@...sung.com>
---
This patch is tested for S5PV210 platform and similar
changes can be adopted for rest of the Samsung's s3c
and s5p platforms, if this approach is accepted.
arch/arm/mach-s5pv210/dev-spi.c | 31 ++++++++++++++++++---
arch/arm/plat-samsung/include/plat/s3c64xx-spi.h | 7 +----
2 files changed, 27 insertions(+), 11 deletions(-)
diff --git a/arch/arm/mach-s5pv210/dev-spi.c b/arch/arm/mach-s5pv210/dev-spi.c
index eaf9a7b..e81b67d 100644
--- a/arch/arm/mach-s5pv210/dev-spi.c
+++ b/arch/arm/mach-s5pv210/dev-spi.c
@@ -11,6 +11,7 @@
#include <linux/platform_device.h>
#include <linux/dma-mapping.h>
#include <linux/gpio.h>
+#include <linux/clk.h>
#include <mach/dma.h>
#include <mach/map.h>
@@ -145,13 +146,15 @@ struct platform_device s5pv210_device_spi1 = {
},
};
-void __init s5pv210_spi_set_info(int cntrlr, int src_clk_nr, int num_cs)
+void __init s5pv210_spi_set_info(int cntrlr, int num_cs)
{
struct s3c64xx_spi_info *pd;
+ struct device *dev;
+ char devname[16], clk_alias_name[16];
+ int ret, i;
/* Reject invalid configuration */
- if (!num_cs || src_clk_nr < 0
- || src_clk_nr > S5PV210_SPI_SRCCLK_SCLK) {
+ if (!num_cs) {
printk(KERN_ERR "%s: Invalid SPI configuration\n", __func__);
return;
}
@@ -159,9 +162,11 @@ void __init s5pv210_spi_set_info(int cntrlr, int src_clk_nr, int num_cs)
switch (cntrlr) {
case 0:
pd = &s5pv210_spi0_pdata;
+ dev = &s5pv210_device_spi0.dev;
break;
case 1:
pd = &s5pv210_spi1_pdata;
+ dev = &s5pv210_device_spi1.dev;
break;
default:
printk(KERN_ERR "%s: Invalid SPI controller(%d)\n",
@@ -169,7 +174,23 @@ void __init s5pv210_spi_set_info(int cntrlr, int src_clk_nr, int num_cs)
return;
}
+ sprintf(devname, "s3c64xx-spi.%d", cntrlr);
+
+ for (i = 0; i < ARRAY_SIZE(spi_src_clks); i++) {
+ sprintf(clk_alias_name, "clk_spi_bus%d", i);
+
+ if (!strcmp(spi_src_clks[i], "pclk"))
+ ret = clk_add_alias(clk_alias_name, devname,
+ spi_src_clks[i], NULL);
+ else
+ ret = clk_add_alias(clk_alias_name, devname,
+ spi_src_clks[i], dev);
+ if (ret) {
+ printk(KERN_ERR "failed to create alias for"
+ " SPI%d source clock%d\n", cntrlr, i);
+ continue;
+ }
+ }
+
pd->num_cs = num_cs;
- pd->src_clk_nr = src_clk_nr;
- pd->src_clk_name = spi_src_clks[src_clk_nr];
}
diff --git a/arch/arm/plat-samsung/include/plat/s3c64xx-spi.h b/arch/arm/plat-samsung/include/plat/s3c64xx-spi.h
index 4c16fa3..70ddd8c 100644
--- a/arch/arm/plat-samsung/include/plat/s3c64xx-spi.h
+++ b/arch/arm/plat-samsung/include/plat/s3c64xx-spi.h
@@ -30,8 +30,6 @@ struct s3c64xx_spi_csinfo {
/**
* struct s3c64xx_spi_info - SPI Controller defining structure
- * @src_clk_nr: Clock source index for the CLK_CFG[SPI_CLKSEL] field.
- * @src_clk_name: Platform name of the corresponding clock.
* @clk_from_cmu: If the SPI clock/prescalar control block is present
* by the platform's clock-management-unit and not in SPI controller.
* @num_cs: Number of CS this controller emulates.
@@ -42,8 +40,6 @@ struct s3c64xx_spi_csinfo {
* @tx_st_done: Depends on tx fifo_lvl field
*/
struct s3c64xx_spi_info {
- int src_clk_nr;
- char *src_clk_name;
bool clk_from_cmu;
int num_cs;
@@ -61,7 +57,6 @@ struct s3c64xx_spi_info {
* s3c64xx_spi_set_info - SPI Controller configure callback by the board
* initialization code.
* @cntrlr: SPI controller number the configuration is for.
- * @src_clk_nr: Clock the SPI controller is to use to generate SPI clocks.
* @num_cs: Number of elements in the 'cs' array.
*
* Call this from machine init code for each SPI Controller that
@@ -69,7 +64,7 @@ struct s3c64xx_spi_info {
*/
extern void s3c64xx_spi_set_info(int cntrlr, int src_clk_nr, int num_cs);
extern void s5pc100_spi_set_info(int cntrlr, int src_clk_nr, int num_cs);
-extern void s5pv210_spi_set_info(int cntrlr, int src_clk_nr, int num_cs);
+extern void s5pv210_spi_set_info(int cntrlr, int num_cs);
extern void s5p64x0_spi_set_info(int cntrlr, int src_clk_nr, int num_cs);
#endif /* __S3C64XX_PLAT_SPI_H */
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists