linux-kernel - Re: [PATCH] uio/gen-pci: don't enable interrupts in ISR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E424255.5060405@linutronix.de>
Date:	Wed, 10 Aug 2011 10:33:25 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	"Michael S. Tsirkin" <mst@...hat.com>
CC:	Chris Wright <chrisw@...hat.com>,
	"Hans J. Koch" <hjk@...sjkoch.de>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Anthony Foiani <anthony.foiani@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uio/gen-pci: don't enable interrupts in ISR

Michael S. Tsirkin wrote:
> Let's assume we start with e.g. io enable bit cleared.
> 
> 
>     user                                kernel
>  read config                               |
>  set io enable                             |
>      |                                  interrupt                                                
>      |                              read + set interrupt mask
>  write config back                         |
> 					write
> 
> 
> 
> We end up with io enable bit cleared. Locking around rmw
> that we have fixes this race.

Okay, forgot about the SMP case, sorry.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/