linux-kernel - RE: [patch v3 6/7] crc32: add-slicing-by-8.diff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OF177C3D3E.3BACC024-ONC12578E8.00345039-C12578E8.003474EE@transmode.se>
Date:	Wed, 10 Aug 2011 11:32:58 +0200
From:	Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
To:	"Bob Pearson" <rpearson@...temfabricworks.com>
Cc:	akpm@...ux-foundation.org, fzago@...temfabricworks.com,
	linux@...izon.com, linux-kernel@...r.kernel.org
Subject: RE: [patch v3 6/7] crc32: add-slicing-by-8.diff

"Bob Pearson" <rpearson@...temfabricworks.com> wrote on 2011/08/09 22:52:34:

> From: "Bob Pearson" <rpearson@...temfabricworks.com>
> To: "'Joakim Tjernlund'" <joakim.tjernlund@...nsmode.se>
> Cc: <akpm@...ux-foundation.org>, <fzago@...temfabricworks.com>, <linux@...izon.com>, <linux-kernel@...r.kernel.org>
> Date: 2011/08/09 22:52
> Subject: RE: [patch v3 6/7] crc32: add-slicing-by-8.diff
>
> > >    - extend largest BITS size from 32 to 64
> > >    - extend table from tab[4][256] to tab[8][256]
> > >    - change algorithm to align on 8 byte boundary
> > >      (it was noted that all that is really required
> > >      is that the inner loop must comsume 8 bytes.
> > >      As written it can start on even or odd 4 byte
> > >      boundary.)
> > So why not do that in the code too?
> >
>
> I did the experiment with the random test set and it is a couple of % faster
> so I made the change. I had thought that it wouldn't make a measurable
> difference.

That could depend on how the test data table is aligned. What if you change
the alignment of the table?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/