linux-kernel - [PATCH] kernel/printk: do not turn off bootconsole in printk_late_init if keep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1312934553-17085-1-git-send-email-nacc@us.ibm.com>
Date:	Tue,  9 Aug 2011 17:02:33 -0700
From:	Nishanth Aravamudan <nacc@...ibm.com>
To:	"Fabio M . Di Nitto" <fabbione@...bione.net>
Cc:	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, Greg KH <gregkh@...e.de>
Subject: [PATCH] kernel/printk: do not turn off bootconsole in printk_late_init if keep_bootcon

It seems that commit 7bf693951a8e5f7e600a45b74d91d962a453146e doesn't
always achieve what it aims, as printk_late_init() runs it
unconditionally turns off all boot consoles. With this patch, I am able
to see more messages on the boot console in KVM guests than I can
without, when keep_bootcon is specified.

Signed-off-by: Nishanth Aravamudan <nacc@...ibm.com>
Cc: David S. Miller <davem@...emloft.net>
Cc: Alan Cox <alan@...rguk.ukuu.org.uk>
Cc: Greg KH <gregkh@...e.de>
---
 kernel/printk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/printk.c b/kernel/printk.c
index 37dff34..293a6cc 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -1602,7 +1602,7 @@ static int __init printk_late_init(void)
 	struct console *con;
 
 	for_each_console(con) {
-		if (con->flags & CON_BOOT) {
+		if (!keep_bootcon && con->flags & CON_BOOT) {
 			printk(KERN_INFO "turn off boot console %s%d\n",
 				con->name, con->index);
 			unregister_console(con);
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/