linux-kernel - Re: [patch 1/2] fuse: delete dead .write_begin and .write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sjp97bm3.fsf@tucsk.pomaz.szeredi.hu>
Date:	Wed, 10 Aug 2011 13:24:36 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Johannes Weiner <jweiner@...hat.com>,
	fuse-devel@...ts.sourceforge.net, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 1/2] fuse: delete dead .write_begin and .write_end aops

Christoph Hellwig <hch@...radead.org> writes:

> On Mon, Aug 08, 2011 at 05:05:20PM +0200, Miklos Szeredi wrote:
>> > The loop code still calls them uncondtionally.  This actually is a big
>> > as write_begin and write_end require filesystems specific locking,
>> > and might require code in the filesystem to e.g. update the ctime
>> > properly.  I'll let Miklos chime in if leaving them in was intentional,
>> > and if it was a comment is probably justified.
>> 
>> Loop checks for ->write_begin() and falls back to ->write if the former
>> isn't defined.
>> 
>> So I think the patch is fine.  I tested loop over fuse, and it still
>> works after the patch.
>
> It works, but it involves another data copy, which will slow down
> various workloads that people at least historically cared about.

AFAICS, normally there isn't an additional copy.  If ->write_begin is
defined the copy from the bio_vec to the filesystem page is done with
transfer_none() in the loop driver.

Otherwise the copy is done by ->write() itself on the kmapped bio.

If there's a crypto transfer function then a temporary page will be used
in the no write_begin case.  But I don't think there the additional copy
makes much difference or that anyone cares.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/