linux-kernel - Re: [PATCH] mfd/ab8500-gpadc: refactor GPADC API, add raw access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbDrSfgjZA+4Xs4qcYW23rhFikMWtRinmp_Fg4bQmv1+w@mail.gmail.com>
Date:	Wed, 10 Aug 2011 15:06:48 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
	Kalle Komierowski <kalle.komierowski@...il.com>
Subject: Re: [PATCH] mfd/ab8500-gpadc: refactor GPADC API, add raw access

On Mon, Jul 4, 2011 at 5:30 PM, Samuel Ortiz <sameo@...ux.intel.com> wrote:
> On Tue, Jun 28, 2011 at 11:08:03AM +0200, Linus Walleij wrote:
>> From: Kalle Komierowski <kalle.komierowski@...il.com>
>>
>> - A bug in the use of the exported functions made the raw ADC
>>   value converted to voltage entity twice.
>
> Please separate this one from the API renaming/clarification.

Sorry that line is just a clarification for the patch itself. The
signature of the functions made that bug occur in consumers
calling the GPADC functions, due to the fact that they
though massaged values were raw.

So by doing this API change the mistake is not that easy
to make again.

I'll reword and repost the patch.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/