linux-kernel - [PATCH 0/2 v2] minor cleanups to EFLAGS initialisation in ret_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Aug 2011 17:29:03 +0100
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	<linux-kernel@...r.kernel.org>
CC:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"H. Peter Anvin" <hpa@...or.com>,
	Pekka Enberg <penberg@...nel.org>,
	Cyrill Gorcunov <gorcunov@...il.com>,
	Andi Kleen <ak@...ux.intel.com>, Ingo Molnar <mingo@...e.hu>,
	Brian Gerst <brgerst@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"x86@...nel.org" <x86@...nel.org>,
	LinusTorvalds <torvalds@...ux-foundation.org>
Subject: [PATCH 0/2 v2] minor cleanups to EFLAGS initialisation in
 ret_from_fork

The following series removes the use of a global kernel_eflags variable
from the x86_64 ret_from_fork path and (very slightly) merges the 32 and
64 bit version of that code path.

kernel_eflags could be made a __read_mostly but actually there is no
reason to prefer the value at cpu_init() time to a compile time constant
value for the initial eflags after a fork.

Test booted on 32 and 64 bit.

changes since v1:
      * rebased onto tip/master
      * make 32 bit look like 64 bit instead of vice versa since the
        behaviour of resetting eflags with interrupts disabled before
        calling schedule_tail seems more obviously safe than resetting
        eflags with interrupts enabled afterwards (although I think both
        are actually correct).
      * As a consequence of the above patch 3/3 (use symbolic names for
        bits in eflags) goes away since we only use the MBO bit 1 now,
        which doesn't have a name.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/