linux-kernel - Re: Allocating buffers for USB transfers (again)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk4alxhs7.wl%tiwai@suse.de>
Date:	Wed, 10 Aug 2011 20:06:48 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Daniel Mack <zonque@...il.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Florian Mickler <florian@...kler.org>,
	Oliver Neukum <oliver@...kum.org>, linux-usb@...r.kernel.org,
	alsa-devel@...a-project.org, Clemens Ladisch <clemens@...isch.de>,
	pedrib@...il.com, William Light <wrl@...est.net>,
	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org,
	Robert Hancock <hancockrwd@...il.com>
Subject: Re: Allocating buffers for USB transfers (again)

At Wed, 10 Aug 2011 17:33:02 +0200,
Daniel Mack wrote:
> 
> On 08/10/2011 04:32 PM, Alan Stern wrote:
> > Looking at the driver's current code, it appears that your patch
> > does not fix the bug properly.  Using discontiguous regions in the
> > transfer buffer is perfectly okay.  The real problem is later on,
> > where you do:
> >
> > if (send_it) { out->number_of_packets = FRAMES_PER_URB;
> >
> > This should be
> >
> > out->number_of_packets = outframe;
> >
> > The way it is now, the USB stack will try to use data from all the
> > frame descriptors, and the last few will be stale because the loop
> > doesn't set them.
> 
> That's actually true, even though it doesn't seem to cause any trouble.
> I tested everything here of course, and the output URBs return back from
> the USB stack with their length fields zeroed out, which then
> causes the stack to send packets with zero-length fields at the end.
> 
> However, doing it right doesn't harm either. Thanks for spotting.
> 
> Takashi, can you apply this version?

Yep, applied now.  Thanks.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/