linux-kernel - Re: [PATCH 02/10] tracing/filter: Separate predicate init and filter addition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1313009501.18583.270.camel@gandalf.stny.rr.com>
Date:	Wed, 10 Aug 2011 16:51:41 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	fweisbec@...il.com, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] tracing/filter: Separate predicate init and
 filter addition

On Thu, 2011-08-04 at 12:08 +0200, Jiri Olsa wrote:
> Separating the filter_pred initialization from code
> that adds the filter_pred to the filter.
> 
> The create_pred returns initialized predicate, which
> is added to the filter by filter_add_pred function.
> 
> Keeping dry_run variable inside replace_preds function.

The only issue I have with this patch is the change log. It tells me
what you are doing, but does not tell us why you are doing it.

I'm pretty clueless about reviewing this patch, as I don't know what the
goal of the patch is. It's like a patch that says, increment i

+ i++;


-- Steve

> 
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/