linux-kernel - Re: [PATCH] drivers/mtd/nand/bcm_umi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1108100749250.22900@ask.diku.dk>
Date:	Wed, 10 Aug 2011 07:49:52 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Jiandong Zheng <jdzheng@...adcom.com>
Cc:	kernel-janitors@...r.kernel.org,
	Scott Branden <sbranden@...adcom.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/mtd/nand/bcm_umi_nand.c: add missing kfree/ioremap

Oops, please ignore this patch.  I missed another similar problem in the 
same function.

julia


On Wed, 10 Aug 2011, Julia Lawall wrote:

> From: Julia Lawall <julia@...u.dk>
> 
> The error handling code under the #if should be the same as elsewhere in
> the function.
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  drivers/mtd/nand/bcm_umi_nand.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/bcm_umi_nand.c b/drivers/mtd/nand/bcm_umi_nand.c
> index a8ae898..72e8ec2 100644
> --- a/drivers/mtd/nand/bcm_umi_nand.c
> +++ b/drivers/mtd/nand/bcm_umi_nand.c
> @@ -433,8 +433,11 @@ static int __devinit bcm_umi_nand_probe(struct platform_device *pdev)
>  
>  #if USE_DMA
>  	err = nand_dma_init();
> -	if (err != 0)
> +	if (err != 0) {
> +		iounmap(bcm_umi_io_base);
> +		kfree(board_mtd);
>  		return err;
> +	}
>  #endif
>  
>  	/* Figure out the size of the device that we have.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/