linux-kernel - Re: [alsa-devel] [PATCH 3/4] ASoC: Blackfin: ADAU1373 eval board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E4220B3.7020105@metafoo.de>
Date:	Wed, 10 Aug 2011 08:09:55 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Scott Jiang <scott.jiang.linux@...il.com>
CC:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	Mike Frysinger <vapier.adi@...il.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	device-drivers-devel@...ckfin.uclinux.org,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [alsa-devel] [PATCH 3/4] ASoC: Blackfin: ADAU1373 eval board
 support

On 08/10/2011 07:27 AM, Scott Jiang wrote:
>> +config SND_SOC_BFIN_EVAL_ADAU1373
>> +       tristate "Support for the EVAL-ADAU1373 board on Blackfin eval boards"
>> +       depends on SND_BF5XX_I2S
>> +       select SND_BF5XX_SOC_I2S
>> +       select SND_SOC_ADAU1373
>> +       select I2C
> 
> Is it better to use depends on I2C?
> 

Not sure, I just kept the scheme used by the other blackfin board drivers. But
I guess it makes some sense change it to 'depends'. Especially if we consider
that there are going to be board drivers with support for both I2C and SPI.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/