linux-kernel - Re: [PATCH v2 2/2] blktrace: add FLUSH/FUA support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E43949A.7000306@fusionio.com>
Date:	Thu, 11 Aug 2011 10:36:42 +0200
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Jeff Moyer <jmoyer@...hat.com>
CC:	Namhyung Kim <namhyung@...il.com>, Christoph Hellwig <hch@....de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v2 2/2] blktrace: add FLUSH/FUA support

On 2011-08-10 15:53, Jeff Moyer wrote:
> Namhyung Kim <namhyung@...il.com> writes:
> 
>> Add FLUSH/FUA support to blktrace. As FLUSH precedes WRITE and/or
>> FUA follows WRITE, use the same 'F' flag for both cases and
>> distinguish them by their (relative) position. The end results
>> look like (other flags might be shown also):
>>
>>  - WRITE:            W
>>  - WRITE_FLUSH:      FW
>>  - WRITE_FUA:        WF
>>  - WRITE_FLUSH_FUA:  FWF
> 
> I was hoping we'd go with Jens' suggestion of relacing W with F for flush,
> and have FUA appear after that.  However, I can live with this, so if
> others like it, it's fine by me.

The single 'F' would have been cleaner, but at least this is consistent.
Applied, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/