linux-kernel - [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1313058586-24239-1-git-send-email-mmarek@suse.cz>
Date:	Thu, 11 Aug 2011 12:29:46 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	dedekind1@...il.com, adrian.hunter@...el.com
Cc:	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled

With
  $ grep -e UBIFS_FS_DEBUG -e DYNAMIC_DEBUG .config
  # CONFIG_UBIFS_FS_DEBUG is not set
  CONFIG_DYNAMIC_DEBUG=y

Debug messages are kept in the object files due to the
dynamic_pr_debug() macro, even if they are never going to be printed:
  $ make fs/ubifs/super.o
  $ strings fs/ubifs/super.o | grep 'compiled on'
  compiled on:         Aug 11 2011 at 12:21:38

Use plain printk to fix this.

Signed-off-by: Michal Marek <mmarek@...e.cz>
---
 fs/ubifs/debug.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ubifs/debug.h b/fs/ubifs/debug.h
index 45174b5..5163a01 100644
--- a/fs/ubifs/debug.h
+++ b/fs/ubifs/debug.h
@@ -337,7 +337,7 @@ void dbg_debugfs_exit_fs(struct ubifs_info *c);
 
 #define ubifs_dbg_msg(fmt, ...) do {               \
 	if (0)                                     \
-		pr_debug(fmt "\n", ##__VA_ARGS__); \
+		printk(KERN_DEBUG fmt "\n", ##__VA_ARGS__); \
 } while (0)
 
 #define dbg_dump_stack()
-- 
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/