linux-kernel - Re: [ANNOUNCE] 3.0.1-rt8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1313066498.8491.1.camel@twins>
Date:	Thu, 11 Aug 2011 14:41:38 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Tim Sander <tim.sander@....com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Paul E. McKenney" <paulmck@...ibm.com>,
	linux-rt-users <linux-rt-users@...r.kernel.org>
Subject: Re: [ANNOUNCE] 3.0.1-rt8 - Regression to 3.0-rt7

On Thu, 2011-08-11 at 14:02 +0200, Peter Zijlstra wrote:
> On Thu, 2011-08-11 at 13:30 +0200, Tim Sander wrote:
> > The error does not occur  when configured with 
> > CONFIG_PREEMPT_RT_FULL=y
> > but with 
> > CONFIG_PREEMPT_RTB=y.
> > The same error also happens with
> > CONFIG_PREEMPT_LL=y. (A log is appended after the other log just
> > search for CONFIG_PREEMPT_LL 
> > for starting point). 
> 
> Does the below (on top of -rt8) cure things for you? Shouldn't make a
> difference for PREEMPT_LL though, so maybe there's something else busted
> as well. But from what I can tell PREEMPT_BASE should be fine with such
> things disabling preemption..

Gah, nevermind, I'm sleeping or so..

---
Index: linux-2.6/mm/filemap.c
===================================================================
--- linux-2.6.orig/mm/filemap.c
+++ linux-2.6/mm/filemap.c
@@ -2040,7 +2040,7 @@ size_t iov_iter_copy_from_user_atomic(st
 	char *kaddr;
 	size_t copied;
 
-	BUG_ON(!current->pagefault_disabled);
+	BUG_ON(!(in_atomic() || current->pagefault_disabled));
 	kaddr = kmap_atomic(page, KM_USER0);
 	if (likely(i->nr_segs == 1)) {
 		int left;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/