linux-kernel - Re: [PATCH] mm: Switch NUMA_BUILD and COMPACTION_BUILD to new IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E43D54D.8030202@suse.cz>
Date:	Thu, 11 Aug 2011 15:12:45 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Michal Hocko <mhocko@...e.cz>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Switch NUMA_BUILD and COMPACTION_BUILD to new IS_ENABLED()
 syntax

On 11.8.2011 15:01, Michal Hocko wrote:
> On Thu 11-08-11 14:51:33, Michal Hocko wrote:
>> On Wed 10-08-11 17:12:40, Michal Marek wrote:
>>> Introduced in 3.1-rc1, IS_ENABLED(CONFIG_NUMA) expands to a true value
>>> iff CONFIG_NUMA is set. This makes it easier to grep for code that
>>> depends on CONFIG_NUMA.
> 
> I have just looked closer at all available macros. Wouldn't it make more
> sense to use IS_BUILTIN instead? Both symbols can be only on or off.
> Not that it would make any difference in the end. I even like IS_ENABLED
> naming more.

IS_ENABLED() and IS_BUILTIN() are equivalent for boolean symbols.
IS_BUILTIN() and IS_MODULE() are meant for the (rare) case when someone
needs to distinguish between built in and module for tristate options in
the code.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/