linux-kernel - Re: [PATCH] memcg: fix comment on update nodemask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110811132511.GM8023@tiehlicka.suse.cz>
Date:	Thu, 11 Aug 2011 15:25:11 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"hannes@...xchg.org" <hannes@...xchg.org>,
	"nishimura@....nes.nec.co.jp" <nishimura@....nes.nec.co.jp>
Subject: Re: [PATCH] memcg: fix comment on update nodemask

On Thu 11-08-11 08:44:56, KAMEZAWA Hiroyuki wrote:
> 
> > > >  /*
> > > >   * Always updating the nodemask is not very good - even if we have an empty
> > > >   * list or the wrong list here, we can start from some node and traverse all
> > > > @@ -1575,7 +1593,6 @@ static bool test_mem_cgroup_node_reclaim
> > > >   */
> > > 
> > > Would be good to update the function comment as well (we still have 10s
> > > period there).
> > > 
> > 
> how about this ?
> ==
> 
> Update function's comment. The behavior is changed by commit 453a9bf3
> 
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> 
> ---
>  mm/memcontrol.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> Index: mmotm-Aug3/mm/memcontrol.c
> ===================================================================
> --- mmotm-Aug3.orig/mm/memcontrol.c
> +++ mmotm-Aug3/mm/memcontrol.c
> @@ -1568,10 +1568,7 @@ static bool test_mem_cgroup_node_reclaim
>  #if MAX_NUMNODES > 1
>  
>  /*
> - * Always updating the nodemask is not very good - even if we have an empty
> - * list or the wrong list here, we can start from some node and traverse all
> - * nodes based on the zonelist. So update the list loosely once per 10 secs.
> - *
> + * Update scan nodemask with memcg's event_counter(NUMAINFO_EVENTS_TARGET)
>   */
>  static void mem_cgroup_may_update_nodemask(struct mem_cgroup *mem)
>  {

I would keep the first part about reasoning and just replace the one
about 10 secs update.

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/