linux-kernel - Re: [PATCH 0/10] ftrace/filter: Trace events filtering related fixies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110811142126.GC2065@jolsa.brq.redhat.com>
Date:	Thu, 11 Aug 2011 16:21:26 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	fweisbec@...il.com, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/10] ftrace/filter: Trace events filtering related fixies

On Wed, Aug 10, 2011 at 05:25:35PM -0400, Steven Rostedt wrote:
> On Thu, 2011-08-04 at 12:08 +0200, Jiri Olsa wrote:
> > hi,
> > 
> > on the way to perf/ftrace filtering changes, I made some changes
> > to the current events filtering code. It could be divided into 3
> > parts roughly:
> > 
> > - remove unnecessary dynamic allocations (patches 1 - 4)
> > - unify the predicate tree walking (patches 5 - 9)
> > - added startup test for event filtering (patch 10)
> > 
> > attached patches:
> > - 01/10 tracing/filter: Use static allocation for filter predicates
> > - 02/10 tracing/filter: Separate predicate init and filter addition
> > - 03/10 tracing/filter: Remove field_name from filter_pred struct
> > - 04/10 tracing/filter: Simplify tracepoint event lookup
> > - 05/10 tracing/filter: Unify predicate tree walking, change check_pred_tree function to use it
> > - 06/10 tracing/filter: Change count_leafs function to use walk_pred_tree
> > - 07/10 tracing/filter: Change fold_pred_tree function to use walk_pred_tree
> > - 08/10 tracing/filter: Change fold_pred function to use walk_pred_tree
> > - 09/10 tracing/filter: Change filter_match_preds function to use walk_pred_tree
> > - 10/10 tracing/filter: Add startup tests for events filter
> 
> Other than the comments I made, I really like this patch set. Thanks a
> lot for the hard work put into this!
> 
> If you do an update, I'll pull it into my queue for 3.2.

thanks for comments, I'll send out v2 shortly

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/