linux-kernel - RE: [PATCH RESEND] Input: tegra-kbc - correct call to input_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04AEA24C0A@HQMAIL01.nvidia.com>
Date:	Thu, 11 Aug 2011 09:42:54 -0700
From:	Stephen Warren <swarren@...dia.com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rakesh Iyer <riyer@...dia.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: RE: [PATCH RESEND] Input: tegra-kbc - correct call to
 input_free_device

Axel Lin wrote at Thursday, August 11, 2011 2:49 AM:
> If kzalloc for kbc fails, then we have NULL pointer dereference while
> calling input_free_device(kbc->idev) in the error handling.
> So it is safer to always use the original name, input_dev.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Reviewed-by: Stephen Warren <swarren@...dia.com>

> ---
>  drivers/input/keyboard/tegra-kbc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index 2b3b73e..8e40f2b 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -701,7 +701,7 @@ err_iounmap:
>  err_free_mem_region:
>  	release_mem_region(res->start, resource_size(res));
>  err_free_mem:
> -	input_free_device(kbc->idev);
> +	input_free_device(input_dev);
>  	kfree(kbc);
> 
>  	return err;
> --
> 1.7.4.1

-- 
nvpublic