linux-kernel - Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110811165911.GA6454@tj-desktop>
Date:	Thu, 11 Aug 2011 12:59:11 -0400
From:	Tracey Dent <tdent48227@...il.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	gregkh@...e.de
Subject: Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not
 selected

On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
> 
> > When you try to build INTEL_MID_PTI without having PCI
> > enabled. It fails like this-
> > 
> >  CC [M]  drivers/misc/pti.o
> >  drivers/misc/pti.c: In function ‘pti_pci_remove’:
> >  drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> >  drivers/misc/pti.c: In function ‘pti_pci_probe’:
> >  drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> > 
> > So make INTEL_MID_PTI depend on PCI to fix build error.
> 
> I think (hope) that Greg already has a patch like this queued.
> Greg- are you planning to push some patches soon?
> 
>

Okay, sorry for the noise then.
 
> > Signed-off-by: Tracey Dent <tdent48227@...il.com>
> > ---
> >  drivers/misc/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > index 0a4d86c..2d6423c 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -146,6 +146,7 @@ config PHANTOM
> >  
> >  config INTEL_MID_PTI
> >  	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
> > +	depends on PCI
> >  	default n
> >  	help
> >  	  The PTI (Parallel Trace Interface) driver directs
> > -- 
> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***

regards,

Tracey Dent
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/