linux-kernel - [PATCH 2/5] trace-cmd: Don't call exit from tracecmd_blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1313091459-12049-2-git-send-email-vnagarnaik@google.com>
Date:	Thu, 11 Aug 2011 12:37:36 -0700
From:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>, linux-kernel@...r.kernel.org,
	Vaibhav Nagarnaik <vnagarnaik@...gle.com>
Subject: [PATCH 2/5] trace-cmd: Don't call exit from tracecmd_blk_hack()

Commit 9e0fd22b14805a3a3219a99bc5eccebf70f5484a adds a hack to parse
blktrace events. In tracecmd_blk_hack(), if the block trace events could
not be parsed, it calls exit(0). Get rid of it and only return -1 to let
the caller know that parsing failed.

Signed-off-by: Vaibhav Nagarnaik <vnagarnaik@...gle.com>
---
 trace-blk-hack.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/trace-blk-hack.c b/trace-blk-hack.c
index bdc9d13..b5b78e3 100644
--- a/trace-blk-hack.c
+++ b/trace-blk-hack.c
@@ -159,7 +159,5 @@ int tracecmd_blk_hack(struct tracecmd_input *handle)
 	return 0;
 
  fail:
-	exit(0);
-	printf("failed!\n");
 	return -1;
 }
-- 
1.7.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/