linux-kernel - RE: [PATCH] ARM: tegra: Fix <mach/gpio.h> to have necessary #includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04AEA24CD0@HQMAIL01.nvidia.com>
Date:	Thu, 11 Aug 2011 12:49:47 -0700
From:	Stephen Warren <swarren@...dia.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	Arnd Bergmann <arnd@...db.de>, Colin Cross <ccross@...roid.com>,
	Erik Gilling <konkers@...roid.com>,
	Olof Johansson <olof@...om.net>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ARM: tegra: Fix <mach/gpio.h> to have necessary
 #includes

Russell King wrote at Thursday, August 11, 2011 1:36 PM:
> On Thu, Aug 11, 2011 at 12:05:52PM -0600, Stephen Warren wrote:
> > Without this, EINVAL isn't defined, and type bool isn't declared.
> > This leads to compilation failures.
> 
> An alternative approach would be to convert tegra to be able to use
> the gpiolib __gpio_to_irq() for the on-SoC stuff, and eliminate
> irq_to_gpio().
> 
> Would it be possible to do that instead?

That should work too.

I posted a couple patches last Friday to remove irq_to_gpio:

https://lkml.org/lkml/2011/8/5/343
https://lkml.org/lkml/2011/8/5/342

Later in the thread, you said you would merge them into your branch to
avoid merge conflicts with the other GPIO work you were doing.

For gpio_to_irq, yes, I believe we get rid of it pretty easily; we'd
just need to implement gpio-tegra.c's gpio_chip.to_irq function. Should
I cook up a patch based on top of linux-next plus the two patches above
to do that instead?

Thanks.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/