linux-kernel - Re: [PATCH] mmc: Use pr_<level>, add and use mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110811203416.GA12740@huya.qualcomm.com>
Date:	Thu, 11 Aug 2011 13:34:16 -0700
From:	David Brown <davidb@...eaurora.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Manuel Lauss <manuel.lauss@...il.com>,
	Pavel Pisa <ppisa@...ron.com>,
	David Brown <davidb@...eaurora.org>,
	Daniel Walker <dwalker@...o99.com>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Nicolas Pitre <nico@...xnic.net>,
	Jarkko Lavinen <jarkko.lavinen@...ia.com>,
	Ben Dooks <ben-linux@...ff.org>, Chris Ball <cjb@...top.org>,
	Alex Dubov <oakad@...oo.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Ian Molton <ian@...menth.co.uk>,
	Bruce Chang <brucechang@....com.tw>,
	Harald Welte <HaraldWelte@...tech.com>,
	Tony Olech <tony.olech@...ndigitalsystems.com>,
	Pierre Ossman <pierre@...man.eu>, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-arm-msm@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] mmc: Use pr_<level>, add and use mmc_<level>

On Thu, Aug 11, 2011 at 01:21:24PM -0700, Joe Perches wrote:
> Use current logging styles.
> 
> Add an mmc_printk function to reduce overall size
> by centralizing the mmc_hostname use.
> 
> Because pr_fmt(fmt) KBUILD_MODNAME is used,
> some logging prefixes are changed.
> For instance from "SDIO:" to "mmc_core:"
> 
> Add macros for mmc_err, mmc_warn, and mmc_info.
> Convert printks with mmc_hostname to mmc_<level>.
> 
> Whitespace neatening around pr_<level>.
> Convert printk(KERN_DEBUG to pr_debug(
> Convert direct uses of DBG macros to pr_debug.
> Convert direct uses of DBGF to DBG.
> Coalesce long format strings.
> Add a few missing newlines to logging messages.
> 
> $ size drivers/mmc/built-in.o*
>    text	   data	    bss	    dec	    hex	filename
>   92530	   1608	    204	  94342	  17086	drivers/mmc/built-in.o.minimal.new
>   94229	   1608	    204	  96041	  17729	drivers/mmc/built-in.o.minimal.old
>  291831	   5152	  77344	 374327	  5b637	drivers/mmc/built-in.o.allyesconfig.new
>  293616	   5152	  78128	 376896	  5c040	drivers/mmc/built-in.o.allyesconfig.old
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/mmc/host/msm_sdcc.c     |  103 +++++++++----------

Acked-by: David Brown <davidb@...eaurora.org>

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/