linux-kernel - [PATCH v3] nfs: fix a minor do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E444184.9090109@panasas.com>
Date:	Thu, 11 Aug 2011 13:54:28 -0700
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Chris Metcalf <cmetcalf@...era.com>
CC:	Trond Myklebust <Trond.Myklebust@...app.com>,
	<linux-nfs@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Dean Hildebrand <dhildebz@...ch.edu>
Subject: [PATCH v3] nfs: fix a minor do_div portability issue

On 08/11/2011 12:32 PM, Chris Metcalf wrote:
> This change modifies filelayout_get_dense_offset() to use the functions
> in math64.h and thus avoid a 32-bit platform compile error trying to
> use do_div() on an s64 type.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@...era.com>
> Cc: Boaz Harrosh <bharrosh@...asas.com>

Thanks
Reviewed-by: Boaz Harrosh <bharrosh@...asas.com>

Just if you don't mind a name change. tmp => stripe_no
while at it.

---
From: Chris Metcalf <cmetcalf@...era.com>
Subject: [PATCH v3] nfs: fix a minor do_div portability issue


This change modifies filelayout_get_dense_offset() to use the functions
in math64.h and thus avoid a 32-bit platform compile error trying to
use do_div() on an s64 type.

Signed-off-by: Chris Metcalf <cmetcalf@...era.com>
Reviewed-by: Boaz Harrosh <bharrosh@...asas.com>
---
 fs/nfs/nfs4filelayout.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c
index e8915d4..3ecb14f 100644
--- a/fs/nfs/nfs4filelayout.c
+++ b/fs/nfs/nfs4filelayout.c
@@ -49,12 +49,13 @@ filelayout_get_dense_offset(struct nfs4_filelayout_segment *flseg,
 {
 	u32 stripe_width = flseg->stripe_unit * flseg->dsaddr->stripe_count;
 	u64 stripe_no;
+	u32 rem;
 
 	offset -= flseg->pattern_offset;
-	tmp = offset;
-	do_div(tmp, stripe_width);
+	stripe_no = div_u64(offset, stripe_width);
+	div_u64_rem(offset, flseg->stripe_unit, &rem);
 
-	return tmp * flseg->stripe_unit + do_div(offset, flseg->stripe_unit);
+	return stripe_no * flseg->stripe_unit + rem;
 }
 
 /* This function is used by the layout driver to calculate the
-- 1.6.5.2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/