linux-kernel - Re: Missing put_cpu() in arch/s390/oprofile/hwsampler.c?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110811212354.GD11702@erda.amd.com>
Date:	Thu, 11 Aug 2011 23:23:54 +0200
From:	Robert Richter <robert.richter@....com>
To:	Thomas Meyer <thomas@...3r.de>
CC:	"schwidefsky@...ibm.com" <schwidefsky@...ibm.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Julia Lawall <julia@...u.dk>,
	Heinz Graalfs <graalfs@...ux.vnet.ibm.com>
Subject: Re: Missing put_cpu() in arch/s390/oprofile/hwsampler.c?

On 08.08.11 13:51:53, Thomas Meyer wrote:
> The function hws_oom_callback() seems to miss a corresponding put_cpu().

Yes, it looks broken.

Heinz, can you send a fix please?

Thanks,

-Robert

> 
> Or is this done in another function? I didn't find it.
> 
> thomas
> 
> ---
> 
>  Check for get/put_cpu() imbalances
> 
>  The simplified semantic patch that makes this report is:
> 
> * get_cpu()
> ... when != put_cpu()
> ? get_cpu()
> 
> drivers/crypto/n2_core.c:986:25-26: WARNING: Possible missing put_cpu()!
> drivers/crypto/n2_core.c:1041:25-26: WARNING: Possible missing put_cpu()!
> drivers/scsi/fcoe/fcoe.c:1163:29-30: WARNING: Possible missing put_cpu()!
> drivers/scsi/fcoe/fcoe.c:1630:47-48: WARNING: Possible missing put_cpu()!
> arch/um/sys-i386/ldt.c:53:17-18: WARNING: Possible missing put_cpu()!
> arch/powerpc/kernel/machine_kexec_64.c:188:18-19: WARNING: Possible missing put_cpu()!
> arch/ia64/sn/kernel/sn2/sn_hwperf.c:618:52-53: WARNING: Possible missing put_cpu()!
> arch/s390/oprofile/hwsampler.c:553:16-17: WARNING: Possible missing put_cpu()!
> arch/s390/kernel/vtime.c:430:22-23: WARNING: Possible missing put_cpu()!
> arch/s390/kernel/vtime.c:473:15-16: WARNING: Possible missing put_cpu()!
> arch/blackfin/kernel/cplbinfo.c:89:9-10: WARNING: Possible missing put_cpu()!
> 
> This list contains some false positives.
> 
> Thanks to Julia for the semantic patch to find these kind of errors!
> 
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/