linux-kernel - Re: [patch v5 resending 0/8] Add slicing-by-8 to crc32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF79B4FA74.153E98FD-ONC12578EA.0021A784-C12578EA.0024990B@transmode.se>
Date:	Fri, 12 Aug 2011 08:39:44 +0200
From:	Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
To:	"Bob Pearson" <rpearson@...temfabricworks.com>
Cc:	akpm@...ux-foundation.org, fzago@...temfabricworks.com,
	linux@...izon.com, linux-kernel@...r.kernel.org
Subject: Re: [patch v5 resending 0/8] Add slicing-by-8 to crc32

"Bob Pearson" <rpearson@...temfabricworks.com> wrote on 2011/08/11 19:52:01:
>
> Resending the patch series by hand. I have been having a lot of problems
> trying to
> Figure out how to make quilt and thunderbird play together. Please let me
> Know of this one is better. I have never been able to get quilt to
> Make a mbox that my thunderbird likes but Frank has been able to do it.
> The last time I imported a mbox into thunderbird as Unsent Messages and then
> Edited each note and typed send but for some reason there was a lot of
> breakage.
> This time I just used the external editor to read in each patch from the
> patches
> Directory one a time.

I am not even going to try. After a quick look the still look broken and
several my earlier remarks appears to be ignored.
The changes to gen_crc32table.c looks random, where did this come from
(in v5 6/8):
 -static uint32_t crc32table_le[4][LE_TABLE_SIZE];
-static uint32_t crc32table_be[4][BE_TABLE_SIZE];
+static uint32_t crc32table_le[4][256];
+static uint32_t crc32table_be[4][256];

 Jocke

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/