linux-kernel - Re: [PATCH] staging: IIO: DAC: Delete useless label error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E44E95F.6070402@cam.ac.uk>
Date:	Fri, 12 Aug 2011 09:50:39 +0100
From:	Jonathan Cameron <jic23@....ac.uk>
To:	stufever@...il.com
CC:	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	gregkh@...e.de, Wang Shaoyan <wangshaoyan.pt@...bao.com>
Subject: Re: [PATCH] staging: IIO: DAC: Delete useless label error_ret in
 ade7854.c

On 08/06/11 19:24, stufever@...il.com wrote:
> From: Wang Shaoyan <wangshaoyan.pt@...bao.com>
> 
>   drivers/staging/iio/meter/ade7854.c: In function 'ade7854_probe':
>   drivers/staging/iio/meter/ade7854.c:585: warning: label 'error_ret' defined but not used
> 
> The label error_ret is defined, but never used, so delete it to avoid annoying warning.
Have equivalent in our dev tree, but happy to see this version merge instead.
For reference, we have all sparse / coccinelle and smatch warnings fixed in iio-blue.git.

I'll be pushing the cleanup bits of that tree out sometime fairly soon.
> 
> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@...bao.com>
Acked-by: Jonathan Cameron <jic23@....ac.uk>
> ---
>  drivers/staging/iio/meter/ade7854.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c
> index b82659f..ac3f9d5 100644
> --- a/drivers/staging/iio/meter/ade7854.c
> +++ b/drivers/staging/iio/meter/ade7854.c
> @@ -582,7 +582,6 @@ error_unreg_dev:
>  	iio_device_unregister(indio_dev);
>  error_free_dev:
>  	iio_free_device(indio_dev);
> -error_ret:
>  	return ret;
>  }
>  EXPORT_SYMBOL(ade7854_probe);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/