linux-kernel - Re: [PATCH] staging: IIO: DAC: Delete useless label error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E4536FE.40502@cam.ac.uk>
Date:	Fri, 12 Aug 2011 15:21:50 +0100
From:	Jonathan Cameron <jic23@....ac.uk>
To:	Jonathan Cameron <jic23@....ac.uk>
CC:	stufever@...il.com, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org, gregkh@...e.de,
	michael.hennerich@...log.com,
	Wang Shaoyan <wangshaoyan.pt@...bao.com>
Subject: Re: [PATCH] staging: IIO: DAC: Delete useless label error_ret in
 ad5791.c

On 08/12/11 09:51, Jonathan Cameron wrote:
> On 08/06/11 19:09, stufever@...il.com wrote:
>> From: Wang Shaoyan <wangshaoyan.pt@...bao.com>
>>
>>   drivers/staging/iio/dac/ad5791.c: In function 'ad5791_probe':
>>   drivers/staging/iio/dac/ad5791.c:384: warning: label 'error_ret' defined but not used
>>
>> The label error_ret is defined, but never used, so delete it to avoid annoying warning.
> As with other one, this is fixed in iio-blue.git, but I'm happy to see either version merge.
I'm dozing.  This is the third fix for this one.  Greg, pick up which ever one you want!
>>
>> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@...bao.com>
> Acked-by: Jonathan Cameron <jic23@....ac.uk>
>> ---
>>  drivers/staging/iio/dac/ad5791.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c
>> index 64770d2..5b00b70 100644
>> --- a/drivers/staging/iio/dac/ad5791.c
>> +++ b/drivers/staging/iio/dac/ad5791.c
>> @@ -381,7 +381,6 @@ error_put_reg_pos:
>>  	if (!IS_ERR(reg_vdd))
>>  		regulator_put(reg_vdd);
>>  
>> -error_ret:
>>  	return ret;
>>  }
>>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/