linux-kernel - Re: [PATCH 7/7] perf, x86: Implement 64 bit counter support for IBS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110812181145.GI11702@erda.amd.com>
Date:	Fri, 12 Aug 2011 20:11:45 +0200
From:	Robert Richter <robert.richter@....com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/7] perf, x86: Implement 64 bit counter support for IBS

On 02.08.11 07:37:20, Peter Zijlstra wrote:
> On Thu, 2011-07-28 at 15:46 +0200, Robert Richter wrote:
> > +       /*
> > +        * Emulate IbsOpCurCnt in MSRC001_1033 (IbsOpCtl), not
> > +        * supported in all cpus. As this triggered an interrupt, we
> > +        * set the current count to the max count.
> > +        */
> > +       config = buffer[0];
> > +       if (perf_ibs == &perf_ibs_op) {
> > +               config &= ~IBS_OP_CUR_CNT;
> > +               config |= (config & IBS_OP_MAX_CNT) << 36;
> > +       } 
> 
> Shouldn't that be conditional on capability muck?

It doesn't hurt actually, but true, will implement it right with the
capability check.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/