linux-kernel - RE: Tegra I2C driver compilation failure (was: RE: [PATCH] dt: add empty of_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04AEA24F41@HQMAIL01.nvidia.com>
Date:	Fri, 12 Aug 2011 14:08:52 -0700
From:	Stephen Warren <swarren@...dia.com>
To:	Ben Dooks <ben-i2c@...ff.org>
CC:	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jean Delvare <khali@...ux-fr.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	Colin Cross <ccross@...roid.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Axel Lin <axel.lin@...il.com>,
	Rob Herring <robherring2@...il.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	"marc.zyngier@....com" <marc.zyngier@....com>
Subject: RE: Tegra I2C driver compilation failure (was: RE: [PATCH] dt: add
	empty of_get_property for non-dt)

Ben Dooks wrote at Thursday, August 11, 2011 6:48 PM:
> On Tue, Aug 09, 2011 at 09:21:31AM -0700, Stephen Warren wrote:
> > Stephen Warren wrote at Monday, August 08, 2011 1:26 PM:
> > > Rob Herring wrote at Sunday, August 07, 2011 8:38 AM:
> > > > On 08/05/2011 05:50 PM, Stephen Warren wrote:
> > > > > The patch adds empty function of_get_property for non-dt build, so that
> > > > > drivers migrating to dt can save some '#ifdef CONFIG_OF'.
> > > > >
> > > > > This also fixes the current Tegra compile problem in linux-next.
> > > >
> > > > You could just use of_property_read_u32 in the driver. It already has
> > > > empty version and will simplify the driver code some.
> > >
> > > Yes, that would also work.
> > >
> > > Grant, Ben, do you have a preference for which option to choose?
> >
> > Well, all three possible fixes have been posted now:
> >
> > Add ifdef to i2c driver:
> > http://www.spinics.net/lists/linux-tegra/msg01720.html
> >
> > Implement empty of_get_property:
> > http://www.spinics.net/lists/linux-tegra/msg01881.html
> >
> > Switch i2c driver to use of_property_read_u32:
> > http://permalink.gmane.org/gmane.linux.ports.arm.kernel/127807
> >
> > Ben, please could you please pick one of the changes and apply it, so
> > that linux-next compiles for Tegra? Thanks!
> 
> I'll look into this at the weekend, of_property_read_u32 is probably
> a better function to call.

Ben,

Grant said he has merged the following solution:

> > Implement empty of_get_property:
> > http://www.spinics.net/lists/linux-tegra/msg01881.html

... although it's not in linux-next yet.

If you do still want to go ahead with using of_property_read_u32, the
patch to do that will need a fixup to avoid the unsafe cast; let me know
if you want me to update the patch for that or not.

Related, here's the list of outstanding patches for i2c-tegra.c that I'm
aware of:

[PATCH] i2c: Tegra: Add of_match_table
http://www.spinics.net/lists/linux-i2c/msg05898.html

[PATCH] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality
http://www.spinics.net/lists/linux-i2c/msg05396.html

[PATCH] i2c: tegra: fix possible race condition after tx
http://www.spinics.net/lists/linux-i2c/msg06103.html

Hope this helps! Thanks.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/