linux-kernel - Re: [PATCH] rtc: twl: Fix registration vs. init order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1313192212.2970.45.camel@work-vm>
Date:	Fri, 12 Aug 2011 16:36:52 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Todd Poynor <toddpoynor@...gle.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: twl: Fix registration vs. init order

On Wed, 2011-08-10 at 20:20 -0700, Todd Poynor wrote:
> Only register as an RTC device after the hardware has been
> successfully initialized.  The RTC class driver will call
> back to this driver to read a pending alarm, and other
> drivers watching for new devices on the RTC class may
> read the RTC time upon registration.  Such access might
> occur while the RTC is stopped, prior to clearing
> pending alarms, etc.
> 
> The new ordering also avoids leaving the platform
> device drvdata set to an unregistered struct rtc_device *
> on probe errors.
> 
> Signed-off-by: Todd Poynor <toddpoynor@...gle.com>

Thanks! Queued.
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/