linux-kernel - [RFC patch resend] DMAengine/Langwell: put tx descriptor in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJd=RBB+E+=JXtD4zxM8cmnbCsXuu73xtYoaR7qibRqzOVVfCQ@mail.gmail.com>
Date:	Sat, 13 Aug 2011 12:25:32 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	"Koul, Vinod" <vinod.koul@...el.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: [RFC patch resend] DMAengine/Langwell: put tx descriptor in error path

When preparing LLI based periphral transfer, if error encountered, the newly
prepared tx descriptor should be put for later recycling.

Signed-off-by: Hillf Danton <dhillf@...il.com>
---

--- a/drivers/dma/intel_mid_dma.c	Sat Aug 13 11:44:46 2011
+++ intel_mid_dma.c	Sat Aug 13 12:32:42 2011
@@ -793,6 +793,7 @@ static struct dma_async_tx_descriptor *i
 				32, 0);
 	if (NULL == desc->lli_pool) {
 		pr_err("MID_DMA:LLI pool create failed\n");
+		midc_desc_put(midc, desc);
 		return NULL;
 	}

@@ -800,6 +801,7 @@ static struct dma_async_tx_descriptor *i
 	if (!desc->lli) {
 		pr_err("MID_DMA: LLI alloc failed\n");
 		pci_pool_destroy(desc->lli_pool);
+		midc_desc_put(midc, desc);
 		return NULL;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/