linux-kernel - Re: [PATCH] ASoC: soc-core: Fix checking return value of debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 14 Aug 2011 13:28:28 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ASoC: soc-core: Fix checking return value of
 debugfs_create_dir

On Sun, Aug 14, 2011 at 11:23:13AM +0800, Axel Lin wrote:
> We have CONFIG_DEBUG_FS guard around the place calling debugfs_create_dir,
> thus debugfs_create_dir returns NULL on failure.

On the other hand the existing code doesn't actually have any problem,
the IS_ERR() won't give false positives, so the changelog isn't really
accurate and if anything we'll introduce a bug if someone cut'n'pastes
the code elsewhere.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/