linux-kernel - Re: [PATCH 1/2] add SA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Aug 2011 19:10:07 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Bruno Prémont <bonbons@...ux-vserver.org>
Cc:	Daniel Lezcano <daniel.lezcano@...e.fr>,
	containers@...ts.linux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] add SA_CLDREBOOT flag

On 08/14, Bruno Prémont wrote:
>
> On Sun, 14 August 2011 Oleg Nesterov <oleg@...hat.com> wrote:
> > On 08/11, Daniel Lezcano wrote:
> > >
> > > Add the SA_CLDREBOOT flag to enable the CLD_REBOOT on SIGCHLD
> > > when a process of a child pid namespace calls the reboot syscall.
> >
> > I doubt this is really useful in general. SIGCHLD doesn't queue,
> > if the parent of init already has the pending SIGCHLD it won't see
> > CLD_REBOOTED anyway. Anyway, you do not need a special helper to
> > fill siginfo.
> >
> > And personally I strongly dislike SA_CLDREBOOT. For what? Imho, this
> > is unnecessary complication. If we want SIGCHLD-on-reboot, just send
> > it unconditionally.
>
> The information that is needed is what options the container did pass
> to sys_reboot().
> Did the container want a reboot or a power-off (or maybe just touch the
> LINUX_REBOOT_CMD_CAD_* status)?
>
> As long as that information can reach parent/reaper of container's init
> the needed functionality should be there.

Sorry, can't understand.

Once again, why do you want SA_CLDREBOOT?

OK, you may be need to pass some info via siginfo (but note that it can
be lost, and you do not need a special helper for that). But why do you
want this hack in sa_flags?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/