linux-kernel - Re: [PATCH 1/3] drivers/staging/rtl8187se: Don't pass huge struct by value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110815095822.7f7e32c5c8ba237b40cca863@canb.auug.org.au>
Date:	Mon, 15 Aug 2011 09:58:22 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Andrea Merello <andreamrl@...cali.it>,
	Andre Nogueira <andre.neo.net@...il.com>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	"David S. Miller" <davem@...emloft.net>,
	Larry Finger <Larry.Finger@...inger.net>,
	Stefan Weil <weil@...l.berlios.de>,
	Ilia Mirkin <imirkin@...m.mit.edu>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] drivers/staging/rtl8187se: Don't pass huge struct
 by value

Hi Jesper,

On Sun, 14 Aug 2011 20:32:49 +0200 (CEST) Jesper Juhl <jj@...osbits.net> wrote:
>
> the "static inline" and defined in the header bits I didn't do because I 
> was afraid that that was not valid in combination with EXPORT_SYMBOL().

You don't need to/cannot EXPORT_SYMBOL() static inlines in header files.
Any use in modules will pick up the static inline definition from the
header file when they are built.  Unless, of course, someone takes the
addresses of these functions, then you should not inline them.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped