linux-kernel - [PATCH] acpi: Fix build warnings for missing const on register_hotplug_dock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1313334243-17765-1-git-send-email-kjwinchester@gmail.com>
Date:	Sun, 14 Aug 2011 12:04:03 -0300
From:	Kevin Winchester <kjwinchester@...il.com>
To:	lenb@...nel.org
Cc:	Kevin Winchester <kjwinchester@...il.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] acpi: Fix build warnings for missing const on register_hotplug_dock_device static inline version

    commit 9c8b04be443b33939f374a811c82abeebe0a61d1
    Author: Vasiliy Kulikov <segoon@...nwall.com>
    Date:   Sat Jun 25 21:07:52 2011 +0400

        ACPI: constify ops structs

missed the static inline definition in include/acpi/acpi_drivers.h
for !CONFIG_ACPI_DOCK.  This leads to warnings from:

gcc (GCC) 4.6.1

such as:

drivers/ata/libata-acpi.c: In function ‘ata_acpi_associate’:
drivers/ata/libata-acpi.c:266:11: warning: passing argument 2 of ‘register_hotplug_dock_device’ discards ‘const’ qualifier from pointer target type [enabled by default]
include/acpi/acpi_drivers.h:146:19: note: expected ‘struct acpi_dock_ops *’ but argument is of type ‘const struct acpi_dock_ops *’
drivers/ata/libata-acpi.c:275:11: warning: passing argument 2 of ‘register_hotplug_dock_device’ discards ‘const’ qualifier from pointer target type [enabled by default]
include/acpi/acpi_drivers.h:146:19: note: expected ‘struct acpi_dock_ops *’ but argument is of type ‘const struct acpi_dock_ops *’

Signed-off-by: Kevin Winchester <kjwinchester@...il.com>
---
 include/acpi/acpi_drivers.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
index e49c36d..bb145e4 100644
--- a/include/acpi/acpi_drivers.h
+++ b/include/acpi/acpi_drivers.h
@@ -144,7 +144,7 @@ static inline void unregister_dock_notifier(struct notifier_block *nb)
 {
 }
 static inline int register_hotplug_dock_device(acpi_handle handle,
-					       struct acpi_dock_ops *ops,
+					       const struct acpi_dock_ops *ops,
 					       void *context)
 {
 	return -ENODEV;
-- 
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/