linux-kernel - Re: [PATCH] crypto: aesni-intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Aug 2011 15:15:28 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Josh Boyer <jwboyer@...hat.com>
Cc:	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

On Thu, Aug 11, 2011 at 12:40:41PM -0400, Josh Boyer wrote:
> The ablkcipher structure in ablk_ecb_alg is lacking an ivsize setting.
> This causes the algorithm to fail it's self-test when it's registered
> with the error message:
> 
> [    0.806920] alg: skcipher: Failed to load transform for ecb-aes-aesni: -2
> 
> crypto_lookup_skcipher doesn't like a missing ivsize.  Adding the ivsize
> allows the self-test lookup to pass.

That's not right.  ECB does not require an IV and therefore it
shouldn't have a non-zero IV size.

I'm not quite sure what you mean by crypto_lookup_skcipher not
liking a missing IV size.  It appears to handle that case just
fine by returning the algorithm as is.

Can you show me what your /proc/crypto contains after you get the
aformentioned error?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/