linux-kernel - Re: [PATCH 01/20] drivers_base: platform: use always ->name for uevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACxGe6vAG9REwBGk6M225-ZH=h=uGPY2dL7onA1-ct5wpzf1tA@mail.gmail.com>
Date:	Mon, 15 Aug 2011 09:17:01 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	linux-usb@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/20] drivers_base: platform: use always ->name for uevent

On Mon, Aug 15, 2011 at 9:13 AM, Sebastian Andrzej Siewior
<bigeasy@...utronix.de> wrote:
> Grant Likely wrote:
>>>
>>> --- a/drivers/base/platform.c
>>> +++ b/drivers/base/platform.c
>>> @@ -614,7 +614,7 @@ static int platform_uevent(struct device *dev, struct
>>> kobj_uevent_env *env)
>>>               return rc;
>>>
>>>       add_uevent_var(env, "MODALIAS=%s%s", PLATFORM_MODULE_PREFIX,
>>> -               (pdev->id_entry) ? pdev->id_entry->name : pdev->name);
>>> +                       pdev->name);
>>
>> Yes, this looks like the right thing to do to me.  Also, I think the
>> original code is suspect because it causes the uevent data to be
>> different after binding a driver to a device.
>
> Why different? The code matches (pdev->name == id->name) or
> (pdev->name ==  driver->name) so in both cases it should be equal to
> pdev->name.

Ah, true.  So not only was the code wrong, it was completely redundant.  :-)

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/