linux-kernel - [PATCH] avr32/clock.c: Move '#include linux/export.h' to fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Aug 2011 20:02:00 +0200
From:	Peter Huewe <peterhuewe@....de>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	Haavard Skinnemoen <hskinnemoen@...il.com>,
	Hans-Christian Egtvedt <egtvedt@...fundet.no>,
	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Peter Huewe <peterhuewe@....de>
Subject: [PATCH] avr32/clock.c: Move '#include linux/export.h' to fix build failure

This patch fixes a build failure for the avr32 defconfig by moving the include
of linux/export.h to the top of the file where it is needed.

Without the patch the build first warns about:
arch/avr32/mach-at32ap/clock.c:62: warning: data definition has no type
or storage class
arch/avr32/mach-at32ap/clock.c:62: warning: type defaults to 'int' in
declaration of 'EXPORT_SYMBOL'
arch/avr32/mach-at32ap/clock.c:62: warning: parameter names (without
types) in function declaration
(...)

And then fails with
ERROR: "clk_enable" [sound/spi/snd-at73c213.ko] undefined!
ERROR: "clk_disable" [sound/spi/snd-at73c213.ko] undefined!
(...)

This is because the definition of EXPORT_SYMBOL is needed before the
first usage, and thus the include has to be on the top of the file.

While at it, I sorted the include list alphabetically.

KernelVersion: Linux-next 20110812

Signed-off-by: Peter Huewe <peterhuewe@....de>
---
 arch/avr32/mach-at32ap/clock.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/avr32/mach-at32ap/clock.c b/arch/avr32/mach-at32ap/clock.c
index 579d619..78c873a 100644
--- a/arch/avr32/mach-at32ap/clock.c
+++ b/arch/avr32/mach-at32ap/clock.c
@@ -12,10 +12,11 @@
  * published by the Free Software Foundation.
  */
 #include <linux/clk.h>
-#include <linux/err.h>
 #include <linux/device.h>
-#include <linux/string.h>
+#include <linux/err.h>
+#include <linux/export.h>
 #include <linux/list.h>
+#include <linux/string.h>
 
 #include <mach/chip.h>
 
@@ -186,7 +187,6 @@ EXPORT_SYMBOL(clk_get_parent);
 #include <linux/io.h>
 #include <linux/debugfs.h>
 #include <linux/seq_file.h>
-#include <linux/export.h>
 #include "pm.h"
 
 
-- 
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/