linux-kernel - Re: [PATCH] sparse: always enable endian checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110815183358.GA31530@merkur.ravnborg.org>
Date:	Mon, 15 Aug 2011 20:33:59 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Pavel Roskin <proski@....org>, Michal Marek <mmarek@...e.cz>,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparse: always enable endian checks

On Mon, Aug 15, 2011 at 12:04:41PM -0400, Pavel Roskin wrote:
> Checks enabled by __CHECK_ENDIAN__ produce less than a half of the
> sparse warnings.  For instance, the allyesconfig configuration on
> linux-next (tag next-20110812) produces on x86_64:
> 
>                  no __CHECK_ENDIAN__   with __CHECK_ENDIAN__
> stderr bytes:    1155037               1992954 (73% increase)
> stderr lines:    10716                 18657   (74% increase)
> affected files:  1191                  1458    (22% increase)
> 
> It is no longer true that __CHECK_ENDIAN__ produces so many warnings
> that other sparse warnings drown in the noise.
> 
> Janitors going through the whole tree are already prepared to search for
> the warnings they want to fix.
> 
> The main point of this patch is to make sure that developers of a
> particular driver who use sparse rarely get all the warnings for their
> code even if they forget to specify __CHECK_ENDIAN__ or mistype it.
> 
> Some developers actually added __CHECK_ENDIAN__ to the driver makefiles
> so they don't forget to use it.  Remove them now.
> 
> Remove all references to __CHECK_ENDIAN__ from the documentation except
> the Chinese version, which would need to be updated separately.
> 
> Signed-off-by: Pavel Roskin <proski@....org>
Acked-by: Sam Ravnborg <sam@...nborg.org>

Maybe ask Michal to merge it?

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/