linux-kernel - Re: [PATCH] dt: add of_alias_scan and of_alias_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110814.233559.1395275660949133114.davem@davemloft.net>
Date:	Sun, 14 Aug 2011 23:35:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shawn.guo@...escale.com
Cc:	shawn.guo@...aro.org, devicetree-discuss@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, patches@...aro.org
Subject: Re: [PATCH] dt: add of_alias_scan and of_alias_get_id

From: Shawn Guo <shawn.guo@...escale.com>
Date: Mon, 15 Aug 2011 14:36:44 +0800

> @@ -245,4 +245,11 @@ void __init of_pdt_build_devicetree(phandle root_node, struct of_pdt_ops *ops)
>         nextp = &allnodes->allnext;
>         allnodes->child = of_pdt_build_tree(allnodes,
>                         of_pdt_prom_ops->getchild(allnodes->phandle), &nextp);
> +
> +       /* Get pointer to "/chosen" and "/aliasas" nodes for use everywhere */
> +       of_chosen = of_find_node_by_path("/chosen");
> +       if (of_chosen == NULL)
> +               of_chosen = of_find_node_by_path("/chosen@0");
> +       of_aliases = of_find_node_by_path("/aliases");
> +       of_alias_scan(dt_alloc);
>  }

There is no dt_alloc variable visible in this function.

I didn't need to use a compiler to find this problem, and neither
do you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/