[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOJsxLFE7osu2Y94OD6YkNrB6jV4UwmM6UCx_djL5OCSCJ2rWg@mail.gmail.com>
Date: Tue, 16 Aug 2011 08:45:17 +0300
From: Pekka Enberg <penberg@...nel.org>
To: Akshay Joshi <me@...hayjoshi.com>
Cc: Pavel Machek <pavel@....cz>, Greg Kroah-Hartman <gregkh@...e.de>,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/9] Staging: Winbond: Remove spacing issues related to pointers.
On Tue, Aug 16, 2011 at 3:24 AM, Akshay Joshi <me@...hayjoshi.com> wrote:
> This patch ensures that spacing around pointers is consistent and
> follows the kernel coding style.
>
> Signed-off-by: Akshay Joshi <me@...hayjoshi.com>
> ---
> drivers/staging/winbond/wb35rx_f.h | 4 ++--
> drivers/staging/winbond/wb35rx_s.h | 4 ++--
> drivers/staging/winbond/wb35tx_s.h | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/winbond/wb35rx_f.h b/drivers/staging/winbond/wb35rx_f.h
> index 4efc790..8f51136 100644
> --- a/drivers/staging/winbond/wb35rx_f.h
> +++ b/drivers/staging/winbond/wb35rx_f.h
> @@ -8,8 +8,8 @@
> * Interface function declare
> */
> unsigned char Wb35Rx_initial(struct hw_data *pHwData);
> -void Wb35Rx_destroy(struct hw_data * pHwData);
> -void Wb35Rx_stop(struct hw_data * pHwData);
> +void Wb35Rx_destroy(struct hw_data *pHwData);
> +void Wb35Rx_stop(struct hw_data *pHwData);
> void Wb35Rx_start(struct ieee80211_hw *hw);
>
> #endif
> diff --git a/drivers/staging/winbond/wb35rx_s.h b/drivers/staging/winbond/wb35rx_s.h
> index 949e4f5..e99475db 100644
> --- a/drivers/staging/winbond/wb35rx_s.h
> +++ b/drivers/staging/winbond/wb35rx_s.h
> @@ -35,9 +35,9 @@ struct wb35_rx {
> u32 Rx3UrbCancel;
>
> u32 LastR1; /* For RSSI reporting */
> - struct urb * RxUrb;
> + struct urb *RxUrb;
> u32 Ep3ErrorCount2; /* 20060625.1 Usbd for Rx DMA error count */
>
> int EP3VM_status;
> - u8 * pDRx;
> + u8 *pDRx;
> };
> diff --git a/drivers/staging/winbond/wb35tx_s.h b/drivers/staging/winbond/wb35tx_s.h
> index 83b4b0f..fda18d6 100644
> --- a/drivers/staging/winbond/wb35tx_s.h
> +++ b/drivers/staging/winbond/wb35tx_s.h
> @@ -31,8 +31,8 @@ struct wb35_tx {
> u32 EP4vm_state; /* for EP4vm state */
> u32 tx_halt; /* Stopping VM */
>
> - struct urb * Tx4Urb;
> - struct urb * Tx2Urb;
> + struct urb *Tx4Urb;
> + struct urb *Tx2Urb;
>
> int EP2VM_status;
> int EP4VM_status;
If you're doing this, can you please then fix up all the struct
members to be consistent? I personally prefer the perf and x86 style
where you align members like this (with tabs):
u32 EP4vm_state;
u32 tx_halt;
struct urb *Tx4Urb;
etc...
Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists