linux-kernel - [PATCH 1/2] block: Fix queue_flag update when rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1313474539-5540-1-git-send-email-eric@purestorage.com>
Date:	Mon, 15 Aug 2011 23:02:19 -0700
From:	Eric Seppanen <eric@...estorage.com>
To:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	Roland Dreier <roland@...estorage.com>,
	Eric Seppanen <eric@...estorage.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Christoph Hellwig <hch@...radead.org>,
	Dave Jiang <dave.jiang@...el.com>,
	Jens Axboe <jaxboe@...ionio.com>
Subject: [PATCH 1/2] block: Fix queue_flag update when rq_affinity goes from 2 to 1

From: Eric Seppanen <eric@...estorage.com>

Commit 5757a6d76cdf added the QUEUE_FLAG_SAME_FORCE flag, but fails to
clear that flag when the current state is '2' (SAME_COMP + SAME_FORCE)
and the new state is '1' (SAME_COMP).

Cc: Dan Williams <dan.j.williams@...el.com>
Cc: Christoph Hellwig <hch@...radead.org>
Cc: Dave Jiang <dave.jiang@...el.com>
Cc: Jens Axboe <jaxboe@...ionio.com>
Reviewed-by: Roland Dreier <roland@...estorage.com>
Signed-off-by: Eric Seppanen <eric@...estorage.com>

---
 block/blk-sysfs.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 0ee17b5..e681805 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -258,11 +258,13 @@ queue_rq_affinity_store(struct request_queue *q, const char *page, size_t count)
 
 	ret = queue_var_store(&val, page, count);
 	spin_lock_irq(q->queue_lock);
-	if (val) {
+	if (val == 2) {
 		queue_flag_set(QUEUE_FLAG_SAME_COMP, q);
-		if (val == 2)
-			queue_flag_set(QUEUE_FLAG_SAME_FORCE, q);
-	} else {
+		queue_flag_set(QUEUE_FLAG_SAME_FORCE, q);
+	} else if (val == 1) {
+		queue_flag_set(QUEUE_FLAG_SAME_COMP, q);
+		queue_flag_clear(QUEUE_FLAG_SAME_FORCE, q);
+	} else if (val == 0) {
 		queue_flag_clear(QUEUE_FLAG_SAME_COMP, q);
 		queue_flag_clear(QUEUE_FLAG_SAME_FORCE, q);
 	}
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/