linux-kernel - Re: [patch] xen-blkback: sync I/O after backend disconnected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Aug 2011 14:56:30 +0800
From:	Joe Jin <joe.jin@...cle.com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Jens Axboe <jaxboe@...ionio.com>,
	Ian Campbell <Ian.Campbell@...citrix.com>,
	Greg Marsden <greg.marsden@...cle.com>,
	Kurt C Hackel <KURT.HACKEL@...cle.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [patch] xen-blkback: sync I/O after backend disconnected

On 08/15/11 22:46, Christoph Hellwig wrote:
> On Mon, Aug 15, 2011 at 12:55:02PM +0800, Joe Jin wrote:
>> When backend disconnect, sync IO requests to the disk.
> 
> Care to explain why?

When backend disconnect, I think we'd better flush all dirty data 
to the disk ASAP.

> 
> Also you'll just need a sync_blockdev, fsync_bdev does far to many
> things that don't make any sense when you don't have a file system
> mounted on a device.
> 

xen-blkback support physical device and loopback file, so I think
here should be fsync_bdev()? 

Thanks,
Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/